DHIL-3364 - Processed review remarks from Andre.

This commit is contained in:
Bas Boterman 2024-09-30 11:59:08 +02:00
parent e20e3a40d1
commit 1cb04c6a2e

View File

@ -171,8 +171,6 @@ paths:
"amount": 34, "amount": 34,
"ovpasNumber": "OV34567", "ovpasNumber": "OV34567",
"verificationCode": "A7H6", "verificationCode": "A7H6",
"xTAT": "3b5f2354-d8a1-4317-bb6e-2c32458bc061",
"xBOT": "0fbdb14c-9306-462e-aca7-765a4980a2f7",
"personalAccountData": "personalAccountData":
{ {
"personalAccountDataId": "47db8a40-3238-4bf5-9284-759e3888bd47", "personalAccountDataId": "47db8a40-3238-4bf5-9284-759e3888bd47",
@ -234,8 +232,8 @@ paths:
"mandateInput": "mandateInput":
{ {
"mandateInputId": "0a875e67-dc9f-4825-a030-d732a2adbfbc", "mandateInputId": "0a875e67-dc9f-4825-a030-d732a2adbfbc",
"mandateType": "directDebitMandateType":
{ "mandateTypeId": 1, "name": "import" }, { "directDebitMandateTypeId": 1, "name": "import" },
"createdOn": "2024-03-22T09:00:00", "createdOn": "2024-03-22T09:00:00",
"bic": "RABONL2U", "bic": "RABONL2U",
"iban": "NL44RABO0123456789", "iban": "NL44RABO0123456789",
@ -255,9 +253,9 @@ paths:
[ [
{ {
"orderCustomerAddressId": "aa50047c-58ac-4f15-9448-ee000dfc6893", "orderCustomerAddressId": "aa50047c-58ac-4f15-9448-ee000dfc6893",
"orderAddressType": "addressType":
{ {
"orderAddressTypeId": 1, "adressTypeId": 1,
"name": "Billing", "name": "Billing",
}, },
"street": "Kon. Julianaplein", "street": "Kon. Julianaplein",
@ -325,8 +323,6 @@ paths:
"amount": 34, "amount": 34,
"ovpasNumber": "OV34567", "ovpasNumber": "OV34567",
"verificationCode": "A7H6", "verificationCode": "A7H6",
"xTAT": "3b5f2354-d8a1-4317-bb6e-2c32458bc061",
"xBOT": "0fbdb14c-9306-462e-aca7-765a4980a2f7",
"personalAccountData": "personalAccountData":
{ {
"name": "Jan de Vries", "name": "Jan de Vries",
@ -370,7 +366,7 @@ paths:
], ],
"mandateInput": "mandateInput":
{ {
"mandateTypeId": 1, "directDebitMandateTypeId": 1,
"createdOn": "2024-03-22T09:00:00", "createdOn": "2024-03-22T09:00:00",
"bic": "RABONL2U", "bic": "RABONL2U",
"iban": "NL44RABO0123456789", "iban": "NL44RABO0123456789",
@ -388,7 +384,7 @@ paths:
"orderCustomerAddresses": "orderCustomerAddresses":
[ [
{ {
"orderAddressTypeId": 1, "addressTypeId": 1,
"street": "Kon. Julianaplein", "street": "Kon. Julianaplein",
"houseNumber": 10, "houseNumber": 10,
"houseNumberSuffix": "a", "houseNumberSuffix": "a",
@ -485,8 +481,6 @@ paths:
"amount": 34, "amount": 34,
"ovpasNumber": "OV34567", "ovpasNumber": "OV34567",
"verificationCode": "A7H6", "verificationCode": "A7H6",
"xTAT": "3b5f2354-d8a1-4317-bb6e-2c32458bc061",
"xBOT": "0fbdb14c-9306-462e-aca7-765a4980a2f7",
"personalAccountData": "personalAccountData":
{ {
"personalAccountDataId": "47db8a40-3238-4bf5-9284-759e3888bd47", "personalAccountDataId": "47db8a40-3238-4bf5-9284-759e3888bd47",
@ -542,8 +536,8 @@ paths:
"mandateInput": "mandateInput":
{ {
"mandateInputId": "0a875e67-dc9f-4825-a030-d732a2adbfbc", "mandateInputId": "0a875e67-dc9f-4825-a030-d732a2adbfbc",
"mandateType": "directDebitMandateType":
{ "mandateTypeId": 1, "name": "import" }, { "directDebitMandateTypeId": 1, "name": "import" },
"createdOn": "2024-03-22T09:00:00", "createdOn": "2024-03-22T09:00:00",
"bic": "RABONL2U", "bic": "RABONL2U",
"iban": "NL44RABO0123456789", "iban": "NL44RABO0123456789",
@ -563,8 +557,8 @@ paths:
[ [
{ {
"orderCustomerAddressId": "aa50047c-58ac-4f15-9448-ee000dfc6893", "orderCustomerAddressId": "aa50047c-58ac-4f15-9448-ee000dfc6893",
"orderAddressType": "addressType":
{ "orderAddressTypeId": 1, "name": "Billing" }, { "addressTypeId": 1, "name": "Billing" },
"street": "Kon. Julianaplein", "street": "Kon. Julianaplein",
"houseNumber": 10, "houseNumber": 10,
"houseNumberSuffix": "a", "houseNumberSuffix": "a",
@ -685,8 +679,6 @@ paths:
"amount": 34, "amount": 34,
"ovpasNumber": "OV34567", "ovpasNumber": "OV34567",
"verificationCode": "A7H6", "verificationCode": "A7H6",
"xTAT": "3b5f2354-d8a1-4317-bb6e-2c32458bc061",
"xBOT": "0fbdb14c-9306-462e-aca7-765a4980a2f7",
"personalAccountData": "personalAccountData":
{ {
"name": "Jan de Vries", "name": "Jan de Vries",
@ -758,7 +750,7 @@ paths:
], ],
"mandateInput": "mandateInput":
{ {
"mandateTypeId": 1, "directDebitMandateTypeId": 1,
"createdOn": "2024-03-22T09:00:00", "createdOn": "2024-03-22T09:00:00",
"bic": "RABONL2U", "bic": "RABONL2U",
"iban": "NL44RABO0123456789", "iban": "NL44RABO0123456789",
@ -804,7 +796,7 @@ paths:
"orderCustomerAddresses": "orderCustomerAddresses":
[ [
{ {
"orderAddressTypeId": 1, "addressTypeId": 1,
"street": "Kon. Julianaplein", "street": "Kon. Julianaplein",
"houseNumber": 10, "houseNumber": 10,
"houseNumberSuffix": "a", "houseNumberSuffix": "a",
@ -1006,8 +998,6 @@ paths:
"amount": 34, "amount": 34,
"ovpasNumber": "OV34567", "ovpasNumber": "OV34567",
"verificationCode": "A7H6", "verificationCode": "A7H6",
"xTAT": "3b5f2354-d8a1-4317-bb6e-2c32458bc061",
"xBOT": "0fbdb14c-9306-462e-aca7-765a4980a2f7",
"personalAccountData": "personalAccountData":
{ {
"personalAccountDataId": "47db8a40-3238-4bf5-9284-759e3888bd47", "personalAccountDataId": "47db8a40-3238-4bf5-9284-759e3888bd47",
@ -1138,8 +1128,6 @@ paths:
"amount": 34, "amount": 34,
"ovpasNumber": "OV34567", "ovpasNumber": "OV34567",
"verificationCode": "A7H6", "verificationCode": "A7H6",
"xTAT": "3b5f2354-d8a1-4317-bb6e-2c32458bc061",
"xBOT": "0fbdb14c-9306-462e-aca7-765a4980a2f7",
"personalAccountData": "personalAccountData":
{ {
"name": "Jan de Vries", "name": "Jan de Vries",
@ -1226,20 +1214,6 @@ paths:
example: 8ZY2 example: 8ZY2
required: false required: false
description: Verification code corresponding to the OVpas. description: Verification code corresponding to the OVpas.
- in: query
name: xtat
schema:
type: string
example: 0fbdb14c-9306-462e-aca7-765a4980a2f7
required: false
description: XTAT of the transit account.
- in: query
name: xbot
schema:
type: string
example: 3b5f2354-d8a1-4317-bb6e-2c32458bc061
required: false
description: XBOT of the token.
responses: responses:
"200": "200":
description: OK description: OK
@ -1259,8 +1233,6 @@ paths:
"amount": 34, "amount": 34,
"ovpasNumber": "OV34567", "ovpasNumber": "OV34567",
"verificationCode": "A7H6", "verificationCode": "A7H6",
"xTAT": "3b5f2354-d8a1-4317-bb6e-2c32458bc061",
"xBOT": "0fbdb14c-9306-462e-aca7-765a4980a2f7",
"personalAccountData": "personalAccountData":
{ {
"personalAccountDataId": "47db8a40-3238-4bf5-9284-759e3888bd47", "personalAccountDataId": "47db8a40-3238-4bf5-9284-759e3888bd47",
@ -1302,8 +1274,6 @@ paths:
"amount": 34, "amount": 34,
"ovpasNumber": "OV34567", "ovpasNumber": "OV34567",
"verificationCode": "A7H6", "verificationCode": "A7H6",
"xTAT": "3b5f2354-d8a1-4317-bb6e-2c32458bc061",
"xBOT": "0fbdb14c-9306-462e-aca7-765a4980a2f7",
} }
responses: responses:
"200": "200":
@ -1584,7 +1554,7 @@ paths:
"mandateInput": "mandateInput":
{ {
"mandateInputId": "0a875e67-dc9f-4825-a030-d732a2adbfbc", "mandateInputId": "0a875e67-dc9f-4825-a030-d732a2adbfbc",
"mandateType": { "mandateTypeId": 1, "name": "import" }, "directDebitMandateType": { "directDebitMandateTypeId": 1, "name": "import" },
"createdOn": "2024-03-22T09:00:00", "createdOn": "2024-03-22T09:00:00",
"bic": "RABONL2U", "bic": "RABONL2U",
"iban": "NL44RABO0123456789", "iban": "NL44RABO0123456789",
@ -1689,7 +1659,7 @@ paths:
required: false required: false
description: The id of the payment. description: The id of the payment.
- in: query - in: query
name: mandateTypeId name: directDebitMandateTypeId
schema: schema:
type: array type: array
items: items:
@ -1747,7 +1717,7 @@ paths:
"mandateInputId": "0a875e67-dc9f-4825-a030-d732a2adbfbc", "mandateInputId": "0a875e67-dc9f-4825-a030-d732a2adbfbc",
"paymentId": "4a7ee6ec-d218-49b7-a5bf-0107945767ee", "paymentId": "4a7ee6ec-d218-49b7-a5bf-0107945767ee",
"orderId": "afa89108-3e40-44ac-8bea-7c7f0f2d4006", "orderId": "afa89108-3e40-44ac-8bea-7c7f0f2d4006",
"mandateType": { "mandateTypeId": 1, "name": "import" }, "directDebitMandateType": { "directDebitMandateTypeId": 1, "name": "import" },
"createdOn": "2024-03-22T09:00:00", "createdOn": "2024-03-22T09:00:00",
"bic": "RABONL2U", "bic": "RABONL2U",
"iban": "NL44RABO0123456789", "iban": "NL44RABO0123456789",
@ -1852,8 +1822,8 @@ paths:
[ [
{ {
"orderCustomerAddressId": "aa50047c-58ac-4f15-9448-ee000dfc6893", "orderCustomerAddressId": "aa50047c-58ac-4f15-9448-ee000dfc6893",
"orderAddressType": "addressType":
{ "orderAddressTypeId": 1, "name": "Billing" }, { "addressTypeId": 1, "name": "Billing" },
"street": "Kon. Julianaplein", "street": "Kon. Julianaplein",
"houseNumber": 10, "houseNumber": 10,
"houseNumberSuffix": "a", "houseNumberSuffix": "a",
@ -1924,7 +1894,7 @@ paths:
example: example:
[ [
{ {
"orderAddressTypeId": 1, "addressTypeId": 1,
"street": "Kon. Julianaplein", "street": "Kon. Julianaplein",
"houseNumber": 10, "houseNumber": 10,
"houseNumberSuffix": "a", "houseNumberSuffix": "a",
@ -1966,7 +1936,7 @@ paths:
required: false required: false
description: The id of the customer on the order. description: The id of the customer on the order.
- in: query - in: query
name: orderAddressTypeId name: addressTypeId
schema: schema:
type: array type: array
items: items:
@ -2029,8 +1999,8 @@ paths:
"orderCustomerAddressId": "aa50047c-58ac-4f15-9448-ee000dfc6893", "orderCustomerAddressId": "aa50047c-58ac-4f15-9448-ee000dfc6893",
"orderCustomerId": "540d8b7a-d626-443f-8f99-c24398604d7a", "orderCustomerId": "540d8b7a-d626-443f-8f99-c24398604d7a",
"orderId": "73cca95a-81d1-468f-a8bf-99b36367001a", "orderId": "73cca95a-81d1-468f-a8bf-99b36367001a",
"orderAddressType": "addressType":
{ "orderAddressTypeId": 1, "name": "Billing" }, { "addressTypeId": 1, "name": "Billing" },
"street": "Kon. Julianaplein", "street": "Kon. Julianaplein",
"houseNumber": 10, "houseNumber": 10,
"houseNumberSuffix": "a", "houseNumberSuffix": "a",
@ -2061,7 +2031,7 @@ paths:
$ref: "#/components/schemas/unavailable" $ref: "#/components/schemas/unavailable"
example: example:
{ {
"orderAddressTypeId": 1, "addressTypeId": 1,
"street": "Kon. Julianaplein", "street": "Kon. Julianaplein",
"houseNumber": 10, "houseNumber": 10,
"houseNumberSuffix": "a", "houseNumberSuffix": "a",