From 9041fb5bf9ee3245ef8e9c92bcb2b7fc1db9e111 Mon Sep 17 00:00:00 2001 From: "b.boterman@htm.nl" Date: Fri, 22 Nov 2024 13:43:18 +0100 Subject: [PATCH] OVPAY-879 - Update after feedback Almando. --- src/openapi/fiko/fiko-crud.yaml | 118 ++++++++++++++++++-------------- 1 file changed, 67 insertions(+), 51 deletions(-) diff --git a/src/openapi/fiko/fiko-crud.yaml b/src/openapi/fiko/fiko-crud.yaml index a821dcb..7fb4d61 100644 --- a/src/openapi/fiko/fiko-crud.yaml +++ b/src/openapi/fiko/fiko-crud.yaml @@ -228,7 +228,7 @@ paths: "documentCode": "VERK_FACTUUR", "accountingPeriod": "2024/10", "transactionDescription": "Dagkaart", - "contraAccount": "220.10419", + "contraAccountNumber": "220.10419", "status": "open", "occurence": 1, "processingFailureInstances": @@ -483,7 +483,7 @@ paths: "documentCode": "VERK_FACTUUR", "accountingPeriod": "2024/10", "transactionDescription": "Dagkaart", - "contraAccount": "220.10419", + "contraAccountNumber": "220.10419", "status": "open", "occurence": 1, "processingFailureInstances": @@ -726,7 +726,8 @@ paths: "contraAccountMetadata": { "contraAccountMetadataId": "e0af8c8f-d421-4567-a14e-48e2a1bb86fb", - "contraAccount": "220.10419", + "contraAccountCode": "123456", + "contraAccountNumber": "220.10419", "validFrom": "2024-03-22T09:00:00", "validUntil": null, }, @@ -750,7 +751,8 @@ paths: "contraAccountMetadata": { "contraAccountMetadataId": "69c562ca-5299-4585-ac92-46fb54aeb99e", - "contraAccount": "220.10538", + "contraAccountCode": "123456", + "contraAccountNumber": "220.10419", "validFrom": "2024-03-22T09:00:00", "validUntil": null, }, @@ -929,13 +931,14 @@ paths: "user": "rmeeuws", "timestamp": "2024-10-04T00:00:00", "correlationId": "a03cd0c2-38b5-4619-b9e3-d6e5b842e127", - "metadataChanges": [ - { - "fieldName": "department", - "oldValue": "900", - "newValue": "999", - } - ] + "metadataChanges": + [ + { + "fieldName": "department", + "oldValue": "900", + "newValue": "999", + }, + ], } responses: "201": @@ -959,11 +962,17 @@ paths: example: 37a8095b-19db-498f-9349-5f37d21c5bdf description: The id of the contra account metadata. - in: query - name: contraAccount + name: contraAccountCode + schema: + type: string + example: 123456 + description: The code of the contra account. + - in: query + name: contraAccountNumber schema: type: string example: 220.10419 - description: The contra account. + description: The number of the contra account. - in: query name: validAt schema: @@ -982,7 +991,8 @@ paths: [ { "contraAccountMetadataId": "37a8095b-19db-498f-9349-5f37d21c5bdf", - "contraAccount": "220.10419", + "contraAccountCode": "123456", + "contraAccountNumber": "220.10419", "validFrom": "2024-03-22T09:00:00", "validUntil": null, }, @@ -1000,7 +1010,8 @@ paths: $ref: "#/components/schemas/unavailable" example: { - "contraAccount": "220.10419", + "contraAccountCode": "123456", + "contraAccountNumber": "220.10419", "validFrom": "2024-03-22T09:00:00", "validUntil": null, } @@ -1038,7 +1049,7 @@ paths: $ref: "#/components/schemas/unavailable" example: { - "contraAccount": "220.10419", + "contraAccountNumber": "220.10419", "validFrom": "2024-03-22T09:00:00", "validUntil": null, } @@ -1079,13 +1090,14 @@ paths: "user": "rmeeuws", "timestamp": "2024-10-04T00:00:00", "correlationId": "a03cd0c2-38b5-4619-b9e3-d6e5b842e127", - "metadataChanges": [ - { - "fieldName": "contraAccountMetadataId", - "oldValue": "873810a3-a11a-4d4d-9af7-395520fa207c", - "newValue": "9a8eb116-5270-4ef9-81ef-fdc2e72c281a", - } - ] + "metadataChanges": + [ + { + "fieldName": "contraAccountMetadataId", + "oldValue": "873810a3-a11a-4d4d-9af7-395520fa207c", + "newValue": "9a8eb116-5270-4ef9-81ef-fdc2e72c281a", + }, + ], } responses: "201": @@ -1259,13 +1271,14 @@ paths: "user": "rmeeuws", "timestamp": "2024-10-04T00:00:00", "correlationId": "a03cd0c2-38b5-4619-b9e3-d6e5b842e127", - "metadataChanges": [ - { - "fieldName": "taxCode", - "oldValue": null, - "newValue": "V21", - } - ] + "metadataChanges": + [ + { + "fieldName": "taxCode", + "oldValue": null, + "newValue": "V21", + }, + ], } responses: "201": @@ -1449,13 +1462,14 @@ paths: "user": "rmeeuws", "timestamp": "2024-10-04T00:00:00", "correlationId": "a03cd0c2-38b5-4619-b9e3-d6e5b842e127", - "metadataChanges": [ - { - "fieldName": "businessOwner", - "oldValue": "Corneel Verstoep", - "newValue": "Mark Verheij", - } - ] + "metadataChanges": + [ + { + "fieldName": "businessOwner", + "oldValue": "Corneel Verstoep", + "newValue": "Mark Verheij", + }, + ], } responses: "201": @@ -1587,13 +1601,14 @@ paths: "user": "rmeeuws", "timestamp": "2024-10-04T00:00:00", "correlationId": "a03cd0c2-38b5-4619-b9e3-d6e5b842e127", - "metadataChanges": [ - { - "fieldName": "isOpen", - "oldValue": "true", - "newValue": "false", - } - ] + "metadataChanges": + [ + { + "fieldName": "isOpen", + "oldValue": "true", + "newValue": "false", + }, + ], } responses: "201": @@ -1754,13 +1769,14 @@ paths: "user": "rmeeuws", "timestamp": "2024-10-04T00:00:00", "correlationId": "a03cd0c2-38b5-4619-b9e3-d6e5b842e127", - "metadataChanges": [ - { - "fieldName": "percentage", - "oldValue": null, - "newValue": "23.456", - }, - ], + "metadataChanges": + [ + { + "fieldName": "percentage", + "oldValue": null, + "newValue": "23.456", + }, + ], } responses: "201":