OVPAY-2032 - Added profile instances to the get token call. #23

Merged
MirjamHTM merged 4 commits from feature/OVPAY-2032 into develop 2025-08-25 13:33:56 +00:00
Showing only changes of commit 4d9e6a831f - Show all commits

View File

@ -310,7 +310,7 @@ paths:
"birthdate": null, "birthdate": null,
"photo": null, "photo": null,
}, },
"profileInstances": [], "gboAgeProfile": null,
"_links": "_links":
{ {
"self": "self":
@ -392,7 +392,7 @@ paths:
"birthdate": null, "birthdate": null,
"photo": null, "photo": null,
}, },
"profileInstances": [], "gboAgeProfile": null,
"_links": "_links":
{ {
"self": "self":
@ -508,18 +508,13 @@ paths:
"lastChangeDate": "2024-08-24T14:15:22Z", "lastChangeDate": "2024-08-24T14:15:22Z",
}, },
}, },
"profileInstances": "gboAgeProfile":
MirjamHTM marked this conversation as resolved Outdated

Willen we hier de hele array teruggeven, of alleen de nu actieve (of lege array als er geen enkel actief profiel is)? Anders moet touchpoint die deductie helemaal gaan doen, terwijl SE die ook al heeft gedaan. Kun je net zo goed alleen die teruggeven.

Of nog mooier: geef direct de gboAgeProfile terug zoals we hem in HTM kernregistratie hebben staan (zie mn andere comment)

Willen we hier de hele array teruggeven, of alleen de nu actieve (of lege array als er geen enkel actief profiel is)? Anders moet touchpoint die deductie helemaal gaan doen, terwijl SE die ook al heeft gedaan. Kun je net zo goed alleen die teruggeven. Of nog mooier: geef direct de gboAgeProfile terug zoals we hem in HTM kernregistratie hebben staan (zie mn andere comment)

Goed punt scheelt touchpoint natuurlijk heel veel werk. Kun jij deze voor mij speccen?

Goed punt scheelt touchpoint natuurlijk heel veel werk. Kun jij deze voor mij speccen?

Heb overal profileInstances in de token Details vervangen door gboAgeProfile object, deze is null als het object niet bestaat, en anders gevuld met het geldige profiel op het token. Gelijk met de specs op de validatie van het gboAgeProfile

Heb overal profileInstances in de token Details vervangen door gboAgeProfile object, deze is null als het object niet bestaat, en anders gevuld met het geldige profiel op het token. Gelijk met de specs op de validatie van het gboAgeProfile
[ {
{ "gboAgeProfileId": 1,
"profileType": "199900100", "name": "Kind (4 t/m 11 jaar)",
MirjamHTM marked this conversation as resolved Outdated

De profileType zal in de praktijk altijd in de range 1-5 liggen en overeen komen met onze gboAgeProfile tabel in ABTProductReference

De profileType zal in de praktijk altijd in de range 1-5 liggen en overeen komen met onze gboAgeProfile tabel in ABTProductReference
"validPeriod": "ageFromInclusive": 4,
{ "ageToInclusive": 11
"fromInclusive": "2021-09-18T13:11:11+02:00", },
"untilInclusive": "2026-01-01T01:00:00+01:00",
},
"xprofit": "ad7c62d0-2fc0-47d4-9307-cf03bf53ef4b",
},
],
"_links": "_links":
{ {
"self": "self":
@ -610,18 +605,13 @@ paths:
}, },
"photo": null, "photo": null,
}, },
"profileInstances": "gboAgeProfile":
[ {
{ "gboAgeProfileId": 1,
"profileType": "199900100", "name": "Kind (4 t/m 11 jaar)",
"validPeriod": "ageFromInclusive": 4,
{ "ageToInclusive": 11
"fromInclusive": "2021-09-18T13:11:11+02:00", },
"untilInclusive": "2026-01-01T01:00:00+01:00",
},
"xprofit": "ad7c62d0-2fc0-47d4-9307-cf03bf53ef4b",
},
],
"_links": "_links":
{ {
"self": "self":
@ -730,18 +720,13 @@ paths:
"lastChangeDate": "2024-08-24T14:15:22Z", "lastChangeDate": "2024-08-24T14:15:22Z",
}, },
}, },
"profileInstances": "gboAgeProfile":
[ {
{ "gboAgeProfileId": 1,
"profileType": "199900100", "name": "Kind (4 t/m 11 jaar)",
"validPeriod": "ageFromInclusive": 4,
{ "ageToInclusive": 11
"fromInclusive": "2021-09-18T13:11:11+02:00", },
"untilInclusive": "2026-01-01T01:00:00+01:00",
},
"xprofit": "ad7c62d0-2fc0-47d4-9307-cf03bf53ef4b",
},
],
"_links": "_links":
{ {
"self": "self":
@ -837,7 +822,7 @@ paths:
"birthdate": null, "birthdate": null,
"photo": null, "photo": null,
}, },
"profileInstances": [], "gboAgeProfile": null,
}, },
{ {
"customerProfileId": 18, "customerProfileId": 18,
@ -858,7 +843,7 @@ paths:
"birthdate": null, "birthdate": null,
"photo": null, "photo": null,
}, },
"profileInstances": [], "gboAgeProfile": null
}, },
{ {
"customerProfileId": 132, "customerProfileId": 132,
@ -879,7 +864,7 @@ paths:
"birthdate": null, "birthdate": null,
"photo": null, "photo": null,
}, },
"profileInstances": [], "gboAgeProfile": null
}, },
{ {
"customerProfileId": 166, "customerProfileId": 166,
@ -903,7 +888,7 @@ paths:
"birthdate": null, "birthdate": null,
"photo": null, "photo": null,
}, },
"profileInstances": [], "gboAgeProfile": null
}, },
{ {
"customerProfileId": 166, "customerProfileId": 166,
@ -924,7 +909,7 @@ paths:
"birthdate": null, "birthdate": null,
"photo": null, "photo": null,
}, },
"profileInstances": [], "gboAgeProfile": null
}, },
{ {
"customerProfileId": 1, "customerProfileId": 1,
@ -945,7 +930,7 @@ paths:
"birthdate": null, "birthdate": null,
"photo": null, "photo": null,
}, },
"profileInstances": [], "gboAgeProfile": null
}, },
], ],
_links: _links:
@ -1045,6 +1030,7 @@ paths:
"ePurse": null, "ePurse": null,
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"gboAgeProfile": null,
"_links": "_links":
{ {
"self": "self":
@ -1122,6 +1108,7 @@ paths:
}, },
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"gboAgeProfile": null,
"_links": "_links":
{ {
"self": "self":
@ -1272,6 +1259,7 @@ paths:
"ePurse": null, "ePurse": null,
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"gboAgeProfile": null,
"_links": "_links":
{ {
"self": "self":
@ -1341,6 +1329,7 @@ paths:
}, },
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"gboAgeProfile": null,
"_links": "_links":
{ {
"self": "self":
@ -1410,6 +1399,7 @@ paths:
"ePurse": null, "ePurse": null,
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"gboAgeProfile": null,
"_links": "_links":
{ {
"self": "self":
@ -1596,6 +1586,7 @@ paths:
"ePurse": null, "ePurse": null,
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"gboAgeProfile": null,
"_links": "_links":
{ {
"self": "self":
@ -1658,6 +1649,7 @@ paths:
"ePurse": null, "ePurse": null,
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"gboAgeProfile": null,
"_links": "_links":
{ {
"self": "self":
@ -1819,6 +1811,7 @@ paths:
"ePurse": null, "ePurse": null,
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"gboAgeProfile": null,
"_links": "_links":
{ {
"self": "self":
@ -1888,6 +1881,7 @@ paths:
}, },
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"gboAgeProfile": null,
"_links": "_links":
{ {
"self": "self":
@ -1957,6 +1951,7 @@ paths:
"ePurse": null, "ePurse": null,
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"gboAgeProfile": null,
"_links": "_links":
{ {
"self": "self":
@ -2180,7 +2175,7 @@ paths:
"ePurse": null, "ePurse": null,
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"profileInstances": [] "gboAgeProfile": null
}, },
"newOvPayToken": "newOvPayToken":
{ {
@ -2197,7 +2192,7 @@ paths:
"ePurse": null, "ePurse": null,
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"profileInstances": [], "gboAgeProfile": null
}, },
"isTransferable": true, "isTransferable": true,
"transferableObjects": "transferableObjects":
@ -2210,7 +2205,7 @@ paths:
"ePurse": true, "ePurse": true,
"personalAccountData": "personalAccountData":
{ "name": true, "birthdate": true, "photo": true }, { "name": true, "birthdate": true, "photo": true },
"profileInstances": true, "gboAgeProfile": true
}, },
"_links": "_links":
{ {
@ -2237,15 +2232,15 @@ paths:
"productInstances": [ "productInstances": [
{ {
"productId": 1, "productId": 1,
"name": "HTM 90% Korting", "name": "HTM 90% Korting EMV",
"status": "Active", "status": "Active",
"isRenewable": true, "isRenewable": true,
"productCategory": { "productCategory": {
"productCategoryId": 1, "productCategoryId": 1,
MirjamHTM marked this conversation as resolved
Review

Waarom is dit product niet transferable? Omdat het in het verleden als einddatum is? Dan moet de status ook ff niet op "Active" staan (SE kijkt naar einddatum product en als die in verleden ligt dan geeft ie "Ended" terug)

Waarom is dit product niet transferable? Omdat het in het verleden als einddatum is? Dan moet de status ook ff niet op "Active" staan (SE kijkt naar einddatum product en als die in verleden ligt dan geeft ie "Ended" terug)
Review

Dit heb ik uit een andere swagger getrokken en is geen representatief voorbeeld. Als je het aan kunt passen naar iets wat wel klopt graag.

Dit heb ik uit een andere swagger getrokken en is geen representatief voorbeeld. Als je het aan kunt passen naar iets wat wel klopt graag.
Review

Heb product naam verandert naar korting voor EMV en het nieuwe token van type 2 ( OV pas gemaakt) dan is het product niet overzetbaar :)

Heb product naam verandert naar korting voor EMV en het nieuwe token van type 2 ( OV pas gemaakt) dan is het product niet overzetbaar :)
"name": "Kortingsabonnement" "name": "Kortingsabonnement"
}, },
"fromInclusive": "2024-11-25T13:25:00+01:00", "fromInclusive": "2025-11-25T13:25:00+01:00",
"untilInclusive": "2024-12-25T03:59:59+01:00", "untilInclusive": "2025-12-25T03:59:59+01:00",
"orderId": "501B17EF-36C4-4039-B92C-6517969B464E", "orderId": "501B17EF-36C4-4039-B92C-6517969B464E",
"orderLineId": "38B17EF-36C4-4039-B92C-4817969B464E", "orderLineId": "38B17EF-36C4-4039-B92C-4817969B464E",
"contractId": "56B17EF-C436-9043-B76C-481797WEB464F", "contractId": "56B17EF-C436-9043-B76C-481797WEB464F",
@ -2270,14 +2265,14 @@ paths:
"ePurse": null, "ePurse": null,
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"profileInstances": [], "gboAgeProfile": null
}, },
"newOvPayToken": "newOvPayToken":
{ {
"customerProfileId": null, "customerProfileId": null,
"ovPayTokenId": null, "ovPayTokenId": null,
"xTat": "32089cc8-d187-47ff-a3a9-5c2558def811", "xTat": "32089cc8-d187-47ff-a3a9-5c2558def811",
"tokenType": { "tokenTypeId": 1, "name": "EMV" }, "tokenType": { "tokenTypeId": 2, "name": "OV-pas physical" },
"alias": null, "alias": null,
"tokenStatus": null, "tokenStatus": null,
"expirationDate": "2028-02-01", "expirationDate": "2028-02-01",
@ -2287,7 +2282,7 @@ paths:
"ePurse": null, "ePurse": null,
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"profileInstances": [], "gboAgeProfile": null
}, },
"isTransferable": false, "isTransferable": false,
"transferableObjects": "transferableObjects":
@ -2300,7 +2295,7 @@ paths:
"ePurse": true, "ePurse": true,
"personalAccountData": "personalAccountData":
{ "name": true, "birthdate": true, "photo": true }, { "name": true, "birthdate": true, "photo": true },
"profileInstances": true, "gboAgeProfile": true,
}, },
"_links": {}, "_links": {},
} }
@ -2324,7 +2319,7 @@ paths:
"ePurse": null, "ePurse": null,
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"profileInstances": [], "gboAgeProfile": null
}, },
"newOvPayToken": "newOvPayToken":
{ {
@ -2341,7 +2336,7 @@ paths:
"ePurse": null, "ePurse": null,
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"profileInstances": [], "gboAgeProfile": null
}, },
"isTransferable": false, "isTransferable": false,
"transferableObjects": "transferableObjects":
@ -2354,7 +2349,7 @@ paths:
"ePurse": true, "ePurse": true,
"personalAccountData": "personalAccountData":
{ "name": true, "birthdate": true, "photo": true }, { "name": true, "birthdate": true, "photo": true },
"profileInstances": true, "gboAgeProfile": true,
}, },
"_links": {}, "_links": {},
} }
@ -2408,16 +2403,13 @@ paths:
"lastChangeDate": "2024-08-24T14:15:22Z", "lastChangeDate": "2024-08-24T14:15:22Z",
}, },
}, },
"profileInstances": [ "gboAgeProfile":
{ {
"profileType": "199900100", "gboAgeProfileId": 1,
"validPeriod": { "name": "Kind (4 t/m 11 jaar)",
"fromInclusive": "2021-09-18T13:11:11+02:00", "ageFromInclusive": 4,
"untilInclusive": "2026-01-01T01:00:00+01:00" "ageToInclusive": 11
}, }
"xprofit": "ad7c62d0-2fc0-47d4-9307-cf03bf53ef4b"
}
]
}, },
"newOvPayToken": "newOvPayToken":
{ {
@ -2434,7 +2426,7 @@ paths:
"ePurse": null, "ePurse": null,
"personalAccountData": "personalAccountData":
{ "name": null, "birthdate": null, "photo": null }, { "name": null, "birthdate": null, "photo": null },
"profileInstances": [], "gboAgeProfile": null
}, },
"isTransferable": false, "isTransferable": false,
"transferableObjects": "transferableObjects":
@ -2451,7 +2443,7 @@ paths:
"birthdate": false, "birthdate": false,
"photo": false, "photo": false,
}, },
"profileInstances": true, "gboAgeProfile": true,
}, },
"_links": {}, "_links": {},
} }
@ -2487,16 +2479,13 @@ paths:
}, },
"photo": null, "photo": null,
}, },
"profileInstances": [ "gboAgeProfile":
{ {
"profileType": "199900100", "gboAgeProfileId": 1,
"validPeriod": { "name": "Kind (4 t/m 11 jaar)",
"fromInclusive": "2021-09-18T13:11:11+02:00", "ageFromInclusive": 4,
"untilInclusive": "2026-01-01T01:00:00+01:00" "ageToInclusive": 11
},
"xprofit": "ad7c62d0-2fc0-47d4-9307-cf03bf53ef4b"
} }
]
}, },
"newOvPayToken": "newOvPayToken":
{ {
@ -2526,16 +2515,13 @@ paths:
}, },
"photo": null, "photo": null,
}, },
"profileInstances": [ "gboAgeProfile":
{ {
"profileType": "133700100", "gboAgeProfileId": 4,
"validPeriod": { "name": "Kind (19 t/m 65 jaar)",
"fromInclusive": "2021-09-18T13:11:11+02:00", "ageFromInclusive": 19,
"untilInclusive": "2026-01-01T01:00:00+01:00" "ageToInclusive": 65
},
"xprofit": "4a2d2c9c-1e5d-4d8a-9c0a-6c0a6c0a6c0a"
} }
]
}, },
"isTransferable": false, "isTransferable": false,
"transferableObjects": "transferableObjects":
@ -2548,7 +2534,7 @@ paths:
"ePurse": false, "ePurse": false,
"personalAccountData": "personalAccountData":
{ "name": true, "birthdate": false, "photo": true }, { "name": true, "birthdate": false, "photo": true },
"profileInstances": false, "gboAgeProfile": false,
}, },
"_links": {}, "_links": {},
} }
@ -2893,6 +2879,13 @@ paths:
"lastChangeDate": "2024-08-24T14:15:22Z", "lastChangeDate": "2024-08-24T14:15:22Z",
}, },
}, },
"gboAgeProfile":
{
"gboAgeProfileId": 1,
"name": "Kind (4 t/m 11 jaar)",
"ageFromInclusive": 4,
"ageToInclusive": 11
},
"_links": "_links":
{ {
"self": "self":