HTM/ovpay
4
0
Fork 0
Code Issues Pull Requests 4 Actions Packages Projects Releases 1 Wiki Activity

features/OVPAY2294-vouchers-in-orders #45

Merged
MirjamHTM merged 10 commits from features/OVPAY2294-vouchers-in-orders into develop 2025-12-16 13:57:40 +00:00
Conversation 0 Commits 10 Files Changed 1 +10 -24
1 changed files with 10 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit bfaa1ddcb1 - Show all commits

34
src/openapi/orders/orders-crud.yaml
View File

@ -60,6 +60,7 @@ paths:
name: deviceId name: deviceId
schema: schema:
type: string type: string
format: uuid
example: "7a28bd54-7ca9-499a-a722-d15ab858ab99" example: "7a28bd54-7ca9-499a-a722-d15ab858ab99"
required: false required: false
description: The id of the device used to place the order. description: The id of the device used to place the order.
@ -176,18 +177,7 @@ paths:
"issuedVoucher":{ "issuedVoucher":{
bboterm commented 2025-12-15 16:03:31 +00:00
Review
Copy Link

Even een checkvraag: kan DHIL zonder moeite tabellen uit een ander datamodel joinen in een CRUD?

Even een checkvraag: kan DHIL zonder moeite tabellen uit een ander datamodel joinen in een CRUD?
MirjamHTM commented 2025-12-16 11:15:27 +00:00
Review
Copy Link

Nou dat doen we natuurlijk al voor touchpoint onder andere, dus ik dacht misschien handig om dat hier gelijk te doen, maar ik zat te twijfelen of ik ook de status en claims moet meegeven, misschien alleen het issuedVoucher object.

Nou dat doen we natuurlijk al voor touchpoint onder andere, dus ik dacht misschien handig om dat hier gelijk te doen, maar ik zat te twijfelen of ik ook de status en claims moet meegeven, misschien alleen het issuedVoucher object.
bboterm commented 2025-12-16 12:05:47 +00:00
Review
Copy Link

Ik zou de status en de claims weglaten idd.

Ik zou de status en de claims weglaten idd.
👍 1
"issuedVoucherId": "a0996218-bc5e-4826-9020-cda98a32838d", "issuedVoucherId": "a0996218-bc5e-4826-9020-cda98a32838d",
"voucherCode": "Voucher1234", "voucherCode": "Voucher1234",
"voucherStatusInstances": "purchasedProductId": 31,
[
{
"voucherStatus":
{
"voucherStatusId": 2,
"name": "issued"
},
"createdOn": "2025-11-22T13:00:00"
}
],
"productId": 31,
"fromInclusive": "2025-03-22T08:55:00", "fromInclusive": "2025-03-22T08:55:00",
"untillInclusive": "2026-03-22T08:55:00" "untillInclusive": "2026-03-22T08:55:00"
}, },
@ -198,18 +188,7 @@ paths:
"issuedVoucher":{ "issuedVoucher":{
"issuedVoucherId": "54668baf-4905-4e9a-af02-09c170f295ed", "issuedVoucherId": "54668baf-4905-4e9a-af02-09c170f295ed",
"voucherCode": "Voucher124", "voucherCode": "Voucher124",
"voucherStatusInstances": "purchasedProductId": 35,
[
{
"voucherStatus":
{
"voucherStatusId": 2,
"name": "issued"
},
"createdOn": "2025-11-22T13:00:00"
}
],
"productId": 35,
"fromInclusive": "2025-03-22T08:55:00", "fromInclusive": "2025-03-22T08:55:00",
"untillInclusive": "2026-03-22T08:55:00" "untillInclusive": "2026-03-22T08:55:00"
}, },
@ -815,6 +794,13 @@ paths:
[ [
{ {
"orderVoucherId": "19ef6882-8eda-43bf-b48e-9b4ff8745a50", "orderVoucherId": "19ef6882-8eda-43bf-b48e-9b4ff8745a50",
"issuedVoucher":{
"issuedVoucherId": "54668baf-4905-4e9a-af02-09c170f295ed",
"voucherCode": "Voucher124",
"purchasedProductId": 35,
"fromInclusive": "2025-03-22T08:55:00",
"untillInclusive": "2026-03-22T08:55:00"
},
"orderId": "f59e4769-53a0-4156-8991-6f9119ba629f", "orderId": "f59e4769-53a0-4156-8991-6f9119ba629f",
"orderLineId": "eeb86071-4f59-405d-b2be-7d7a77044bfa" "orderLineId": "eeb86071-4f59-405d-b2be-7d7a77044bfa"
} }