Bas Boterman bboterm
0 Followers · 0 Following
  • The Hague, The Netherlands

  • Solution Architect at HTM.

  • Joined on 2024-07-12
Repositories Projects Packages Public Activity Starred Repositories
bboterm commented on pull request HTM/ovpay#8 2024-12-03 13:41:52 +00:00
feature/OVPAY-96

Waarom is deze nou ineens met een hoofdletter?

bboterm commented on pull request HTM/ovpay#8 2024-12-03 13:41:52 +00:00
feature/OVPAY-96

Tobby schrijft voor dat dit endpoint /customers/{customerId}/tokens moet zijn. Doen we dat bewust niet omdat customerId in de JWT zit? Vindt Toby dat OK?

bboterm commented on pull request HTM/ovpay#8 2024-12-03 13:41:52 +00:00
feature/OVPAY-96

Waarom schrijf je hier 'Entries' en niet gewoon wat het zijn? 'ovPayTokens' ?

bboterm commented on pull request HTM/ovpay#8 2024-12-03 13:41:52 +00:00
feature/OVPAY-96

API richtlijnen van Tobby schrijven voor dat je /customers weg kunt laten. Het tokenId is immers al uniek. Tevens is dit pad nu langer dan 3 delen, en dat mag niet.

bboterm commented on pull request HTM/ovpay#8 2024-12-03 13:41:52 +00:00
feature/OVPAY-96

Daarbij, sinds wanneer doen wij aan kebab case? We doen overal gewoon lowercase in urls.

bboterm commented on pull request HTM/ovpay#8 2024-12-03 13:41:52 +00:00
feature/OVPAY-96

Typo: emailAddress (dubbel d, dubbel s)

bboterm commented on pull request HTM/ovpay#8 2024-12-03 13:41:52 +00:00
feature/OVPAY-96

Voer hier liefst gewoon 'Home' in.

bboterm commented on pull request HTM/ovpay#8 2024-12-03 13:41:52 +00:00
feature/OVPAY-96

Vul hier ook gewoon 'Home' in.

bboterm suggested changes for HTM/ovpay#8 2024-12-03 13:41:52 +00:00
feature/OVPAY-96
bboterm commented on pull request HTM/ovpay#8 2024-12-03 13:38:21 +00:00
feature/OVPAY-96

Daarbij, sinds wanneer doen wij aan kebab case? We doen overal gewoon lowercase in urls.

bboterm pushed to main at HTM/ovpay 2024-12-02 13:04:01 +00:00
c000bf1e6e OVPAY-879 - Added bodies for creating trx.
bboterm deleted branch feature/OVPAY-1009 from HTM/ovpay 2024-12-02 10:06:47 +00:00
bboterm deleted branch feature/OVPAY-1145 from HTM/ovpay 2024-12-02 10:02:38 +00:00
bboterm pushed to develop at HTM/ovpay 2024-12-02 10:02:31 +00:00
013553fba2 Merge pull request 'feature/OVPAY-1145 - add tokenTypes array to ABTProducts list response model' (#7) from feature/OVPAY-1145 into develop
6d9712cdeb Merge branch 'develop' into feature/OVPAY-1145
b020a02c82 OVPAY-1145 - add tokenTypes array to products list respnse model schema and examples
Compare 3 commits »
bboterm merged pull request HTM/ovpay#7 2024-12-02 10:02:30 +00:00
feature/OVPAY-1145 - add tokenTypes array to ABTProducts list response model
bboterm pushed to develop at HTM/ovpay 2024-12-02 09:58:49 +00:00
9cde41bfc3 Update customer YAMLs on develop.
bboterm deleted branch feature/OVPAY-754 from HTM/ovpay 2024-12-02 09:46:36 +00:00
bboterm pushed to develop at HTM/ovpay 2024-12-02 09:46:31 +00:00
98babaeb91 Merge pull request 'OVPAY-754 - Added find on directdebitmandate.' (#3) from feature/OVPAY-754 into develop
bfea9a5967 OVPAY-754 - Fixed PR remarks. Thanks maks.
f7a56f3e62 OVPAY-754 - Added find on directdebitmandate.
Compare 3 commits »
bboterm merged pull request HTM/ovpay#3 2024-12-02 09:46:29 +00:00
OVPAY-754 - Added find on directdebitmandate.
bboterm pushed to feature/OVPAY-754 at HTM/ovpay 2024-12-02 09:46:12 +00:00
bfea9a5967 OVPAY-754 - Fixed PR remarks. Thanks maks.