HTM/ovpay
4
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases 1 Wiki Activity

Reworked SE purchasedproducts endpoints, added vouchers and device to TP order and updated order CRUD deviceId -> externalDeviceId #56

Merged
maxmartens merged 6 commits from features/OVPAY2294-vouchers-in-orders into develop 2026-03-29 17:07:39 +00:00
Conversation 0 Commits 6 Files Changed 7 +2047 -839
MirjamHTM commented 2026-03-23 15:45:13 +00:00
Owner
Copy Link

WIP

WIP
MirjamHTM added 1 commit 2026-03-23 15:45:13 +00:00
maxmartens added 1 commit 2026-03-25 16:38:40 +00:00
maxmartens added 1 commit 2026-03-25 17:31:10 +00:00
maxmartens added 1 commit 2026-03-26 17:45:50 +00:00
maxmartens changed title from added vouchers and device to TP order and updated order CRUD deviceId -> externalDeviceId to Reworked SE purchasedproducts endpoints, added vouchers and device to TP order and updated order CRUD deviceId -> externalDeviceId 2026-03-26 17:46:20 +00:00
MirjamHTM reviewed 2026-03-27 09:55:49 +00:00
MirjamHTM left a comment
Author
Owner
Copy Link

In de purchasedProducts Crud mist serviceId volgens mij, ik zag die wel in het datamodel staan. Ik heb de order SE dingen niet gereviewd, want die zijn van mijzelf, ga niet mijn eigen vlees keuren ;)

In de purchasedProducts Crud mist serviceId volgens mij, ik zag die wel in het datamodel staan. Ik heb de order SE dingen niet gereviewd, want die zijn van mijzelf, ga niet mijn eigen vlees keuren ;)
src/openapi/orders/orders-crud.yaml Outdated
@ -61,3 +60,4 @@
name: externalDeviceId
schema:
type: string
format: uuid
MirjamHTM commented 2026-03-27 09:46:17 +00:00
Author
Owner
Copy Link

Volgens mag deze eraf als we de aanpassing hebben voor db naar string en niet uuid hebben gedaan.

Volgens mag deze eraf als we de aanpassing hebben voor db naar string en niet uuid hebben gedaan.
👍 1
maxmartens marked this conversation as resolved
src/openapi/products/purchased_products-crud.yaml Outdated
@ -170,6 +170,7 @@ paths:
"lastUpdatedOn": "2024-10-04T12:34:56.000",
"createdBy": "user",
"lastUpdatedBy": "user",
"externalDeviceId": "c5545584-04af-4c60-a955-d6a70baab848"
MirjamHTM commented 2026-03-27 09:51:05 +00:00
Author
Owner
Copy Link

Ik mis hier volgens mij het serviceId

Ik mis hier volgens mij het serviceId
👍 1
maxmartens marked this conversation as resolved
src/openapi/products/purchased_products-crud.yaml Outdated
@ -341,6 +342,7 @@ paths:
"lastUpdatedOn": "2024-10-04T12:34:56.000",
"createdBy": "user",
"lastUpdatedBy": "user",
"externalDeviceId": "c5545584-04af-4c60-a955-d6a70baab848"
MirjamHTM commented 2026-03-27 09:51:51 +00:00
Author
Owner
Copy Link

Idem

Idem
👍 1
maxmartens marked this conversation as resolved
src/openapi/products/purchased_products-crud.yaml
@ -910,0 +903,4 @@
schema:
type: string
example: c5545584-04af-4c60-a955-d6a70baab848
description: The external id of the device.
MirjamHTM commented 2026-03-27 09:53:36 +00:00
Author
Owner
Copy Link

Query op serviceId

Query op serviceId
👍 1
maxmartens marked this conversation as resolved
src/openapi/products/purchased_products-crud.yaml
@ -1181,0 +1216,4 @@
example: John Doe
externalDeviceId:
type: string
example: c5545584-04af-4c60-a955-d6a70baab848
MirjamHTM commented 2026-03-27 09:53:21 +00:00
Author
Owner
Copy Link

ServiceId

ServiceId
👍 1
maxmartens marked this conversation as resolved
maxmartens added 1 commit 2026-03-27 10:12:42 +00:00
maxmartens added 1 commit 2026-03-27 10:22:56 +00:00
maxmartens merged commit 2094ef46e4 into develop 2026-03-29 17:07:39 +00:00
maxmartens deleted branch features/OVPAY2294-vouchers-in-orders 2026-03-29 17:07:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: HTM/ovpay#56
No description provided.
Delete Branch "features/OVPAY2294-vouchers-in-orders"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?