HTM/ovpay
4
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases 1 Wiki Activity

Reworked SE purchasedproducts endpoints, added vouchers and device to TP order and updated order CRUD deviceId -> externalDeviceId #56

Merged
maxmartens merged 6 commits from features/OVPAY2294-vouchers-in-orders into develop 2026-03-29 17:07:39 +00:00
Conversation 0 Commits 6 Files Changed 7 +20 -8
3 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit cf7dcc8dd4 - Show all commits

8
src/openapi/customers/SE-customers-v2.yaml
View File

@ -3402,7 +3402,7 @@ paths:
"orderId": "501B17EF-36C4-4039-B92C-6517969B464E",
"orderLineId": "38B17EF-36C4-4039-B92C-4817969B464E",
"ticketReference": "KJj43nejhbTxhrfef287",
"serviceId": "DEF-4321-7654-7659",
"serviceId": "HTM-4321-7654-7659",
"issuedAt": "2026-03-21T09:01:35",
"activatedAt": null,
"blocked": false,
@ -3435,7 +3435,7 @@ paths:
"orderId": "501B17EF-36C4-4039-B92C-6517969B464E",
"orderLineId": "38B17EF-36C4-4039-B92C-4817969B464E",
"ticketReference": "KJj43nejhbTxhr897287",
"serviceId": "ABC-1234-7654-8945",
"serviceId": "HTM-1234-7654-8945",
"issuedAt": "2026-03-21T10:01:12",
"activatedAt": "2026-03-21T12:45:01",
"blocked": false,
@ -3610,7 +3610,7 @@ paths:
"orderId": "501B17EF-36C4-4039-B92C-6517969B464E",
"orderLineId": "38B17EF-36C4-4039-B92C-4817969B464E",
"ticketReference": "KJj43nejhbTxhr897287",
"serviceId": "ABC-1234-7654-8945",
"serviceId": "HTM-1234-7654-8945",
"issuedAt": "2026-03-21T10:01:12",
"activatedAt": "2026-03-21T12:45:01",
"blocked": false,
@ -4442,7 +4442,7 @@ components:
example: KJj43nejhbTxhr897287
serviceId:
type: string
example: ABC-1234-7654-8945
example: HTM-1234-7654-8945
issuedAt:
type: string
format: date-time-offset

1
src/openapi/orders/orders-crud.yaml
View File

@ -60,7 +60,6 @@ paths:
name: externalDeviceId
schema:
type: string
format: uuid
example: "7a28bd54-7ca9-499a-a722-d15ab858ab99"
maxmartens marked this conversation as resolved Outdated
MirjamHTM commented 2026-03-27 09:46:17 +00:00
Outdated
Review
Copy Link

Volgens mag deze eraf als we de aanpassing hebben voor db naar string en niet uuid hebben gedaan.

Volgens mag deze eraf als we de aanpassing hebben voor db naar string en niet uuid hebben gedaan.
👍 1
required: false
description: The external id of the device used to place the order.

19
src/openapi/products/purchased_products-crud.yaml
View File

@ -170,7 +170,8 @@ paths:
"lastUpdatedOn": "2024-10-04T12:34:56.000",
"createdBy": "user",
"lastUpdatedBy": "user",
"externalDeviceId": "c5545584-04af-4c60-a955-d6a70baab848"
"externalDeviceId": "c5545584-04af-4c60-a955-d6a70baab848",
maxmartens marked this conversation as resolved Outdated
MirjamHTM commented 2026-03-27 09:51:05 +00:00
Outdated
Review
Copy Link

Ik mis hier volgens mij het serviceId

Ik mis hier volgens mij het serviceId
👍 1
"serviceId": "HTM-1234-7654-8945"
},
],
"issuedVouchers": [],
@ -342,7 +343,8 @@ paths:
"lastUpdatedOn": "2024-10-04T12:34:56.000",
"createdBy": "user",
"lastUpdatedBy": "user",
maxmartens marked this conversation as resolved Outdated
MirjamHTM commented 2026-03-27 09:51:51 +00:00
Outdated
Review
Copy Link

Idem

Idem
👍 1
"externalDeviceId": "c5545584-04af-4c60-a955-d6a70baab848"
"externalDeviceId": "c5545584-04af-4c60-a955-d6a70baab848",
"serviceId": "HTM-1234-7654-8945"
},
],
"issuedVouchers": [],
@ -904,6 +906,12 @@ paths:
type: string
maxmartens marked this conversation as resolved
MirjamHTM commented 2026-03-27 09:53:36 +00:00
Review
Copy Link

Query op serviceId

Query op serviceId
👍 1
example: c5545584-04af-4c60-a955-d6a70baab848
description: The external id of the device.
- in: query
name: serviceId
schema:
type: string
example: HTM-1234-7654-8945
description: A printable id that needs to be next to the printed barcode on the ticket, which is used when the customer contacts the service desk.
responses:
"200":
description: OK
@ -926,7 +934,8 @@ paths:
"lastUpdatedOn": "2024-10-04T12:34:56.000",
"createdBy": "user",
"lastUpdatedBy": "user",
"externalDeviceId": "c5545584-04af-4c60-a955-d6a70baab848"
"externalDeviceId": "c5545584-04af-4c60-a955-d6a70baab848",
"serviceId": "HTM-1234-7654-8945"
},
],
}
@ -1184,6 +1193,7 @@ components:
- createdOn
- lastUpdatedOn
- createdBy
- serviceId
properties:
issuedAt:
type: string
@ -1217,6 +1227,9 @@ components:
externalDeviceId:
type: string
example: c5545584-04af-4c60-a955-d6a70baab848
serviceId:
type: string
example: HTM-1234-7654-8945
BulkResponseBody:
type: object
properties: